From: Jeremiah Mahler <jmmahler@gmail.com>
Date: Mon, 02 Jun 2014 14:39:05 GMT
Subject: Re: [PATCH v3 0/9] replace signal() with sigaction()
Message-ID: <20140602143905.GA2048@hudson.localdomain>
In-Reply-To: <538C5FD9.1010706@viscovery.net>

Hannes,

On Mon, Jun 02, 2014 at 01:28:25PM +0200, Johannes Sixt wrote:
> Am 6/1/2014 20:10, schrieb Jeremiah Mahler:
> > This is version 3 of the patch set to convert signal(2) to sigaction(2)
> > (previous discussion [1]).
> > 
...
> >   sigchain.c: replace signal() with sigaction()
> 
> The series without patch 9/9 works on Windows so far.
> 
> Without patch patch 9/9 and a more complete implementation of sigaction in
> compat/mingw.c the series misses its goal. But even if you complete it, it
> is IMHO only code churn without practical merits.
> 
> -- Hannes
> 

You are right, I missed the case where the old signal was used, as is
done in sigchain.c.  Sorry about that.

Thanks again for looking at my patch.

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler