Re: [PATCH v3 0/9] replace signal() with sigaction()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 2, 2014, 19:05 UTC
- Message-ID
- <xmqqzjhv3zeu.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <538C5FD9.1010706@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 16 quoted lines
>> Jeremiah Mahler (9): >> compat/mingw.c: expand MinGW support for sigaction >> connect.c: replace signal() with sigaction() >> progress.c: replace signal() with sigaction() >> write_or_die.c: replace signal() with sigaction() >> daemon.c: replace signal() with sigaction() >> builtin/log.c: replace signal() with sigaction() >> builtin/merge-index.c: replace signal() with sigaction() >> builtin/verify-tag.c: replace signal() with sigaction() >> sigchain.c: replace signal() with sigaction() > > The series without patch 9/9 works on Windows so far. > > Without patch patch 9/9 and a more complete implementation of sigaction in > compat/mingw.c the series misses its goal. But even if you complete it, it > is IMHO only code churn without practical merits.
Hmm, you sound a bit harsher than you usually do---although I sort of share with you the doubt on the practical merits.