git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 6/9] builtin/log.c: replace signal() with sigaction()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
Jun 1, 2014, 18:10 UTC
Message-ID
<089731f7d0287838646c52e14a8c4a8bc41dea7d.1401645403.git.jmmahler@gmail.com>
In-Reply-To
<cover.1401645403.git.jmmahler@gmail.com>
From the signal(2) man page:
  The behavior of signal() varies across UNIX versions, and has also var‐
  ied historically across different versions of Linux.   Avoid  its  use:
  use sigaction(2) instead.
Replaced signal() with sigaction() in builtin/log.c
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
 builtin/log.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/builtin/log.c b/builtin/log.c
index 39e8836..f1deea1 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -315,7 +315,11 @@ static void setup_early_output(struct rev_info *rev)
 static void finish_early_output(struct rev_info *rev)
 {
 	int n = estimate_commit_count(rev, rev->commits);
-	signal(SIGALRM, SIG_IGN);
+	struct sigaction sa;
+
+	memset(&sa, 0, sizeof(sa));
+	sa.sa_handler = SIG_IGN;
+	sigaction(SIGALRM, &sa, NULL);
 	show_early_header(rev, "done", n);
 }
 
-- 
2.0.0.8.g7bf6e1f.dirty
Previous: Jeremiah MahlerNext: Jeremiah Mahler
Message 8 of 15 in “replace signal() with sigaction()”
  1. 0/9 replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  2. 1/9 compat/mingw.c: expand MinGW support for sigactionJeremiah Mahler, Jun 1, 2014
  3. Johannes SixtJun 2, 2014
  4. 2/9 connect.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  5. 3/9 progress.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  6. 4/9 write_or_die.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  7. 5/9 daemon.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  8. 6/9 builtin/log.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  9. 7/9 builtin/merge-index.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  10. 8/9 builtin/verify-tag.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  11. 9/9 sigchain.c: replace signal() with sigaction()Jeremiah Mahler, Jun 1, 2014
  12. Johannes SixtJun 2, 2014
  13. Jeremiah MahlerJun 2, 2014
  14. Junio C HamanoJun 2, 2014
  15. Jeremiah MahlerJun 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.