Re: [PATCH 1/2] merge-recursive.c: Fix case-changing merge.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 7, 2014, 18:13 UTC
Message-ID: <20140507181355.GW9218@google.com>
In-Reply-To: <xmqqd2fpbh9b.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> dturner@twopensource.com writes:

Show 6 quoted lines

>> +	test -e testcase
>
> Please make it a habit to use "test -f" when you expect "the path
> exists as a file", not merely "something exists there I do not care
> if it is a file or a directory", for which "test -e" is perfectly
> appropriate.

Or, better in tests,

	test_path_is_file testcase

which prints an error instead of just silently failing when the path is not a file.

Thanks, Jonathan

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.