Re: [PATCH 1/2] merge-recursive.c: Fix case-changing merge.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 7, 2014, 20:53 UTC
- Message-ID
- <xmqqa9at8g56.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140507181355.GW9218@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 11 quoted lines
>> Please make it a habit to use "test -f" when you expect "the path >> exists as a file", not merely "something exists there I do not care >> if it is a file or a directory", for which "test -e" is perfectly >> appropriate. > > Or, better in tests, > > test_path_is_file testcase > > which prints an error instead of just silently failing when > the path is not a file.
Thanks, will tweak.