From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 07 May 2014 18:13:55 GMT
Subject: Re: [PATCH 1/2] merge-recursive.c: Fix case-changing merge.
Message-ID: <20140507181355.GW9218@google.com>
In-Reply-To: <xmqqd2fpbh9b.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:
> dturner@twopensource.com writes:

>> +	test -e testcase
>
> Please make it a habit to use "test -f" when you expect "the path
> exists as a file", not merely "something exists there I do not care
> if it is a file or a directory", for which "test -e" is perfectly
> appropriate.

Or, better in tests,

	test_path_is_file testcase

which prints an error instead of just silently failing when
the path is not a file.

Thanks,
Jonathan