Re: [PATCH 2/2] ignorecase: Fix git mv on insensitive filesystems

From: David Turner <dturner@twopensource.com>
Date: May 7, 2014, 16:42 UTC
Message-ID: <1399480977.11843.62.camel@stross>
In-Reply-To: <5369CFDE.2070207@viscovery.net>

On Wed, 2014-05-07 at 08:17 +0200, Johannes Sixt wrote:

Show 10 quoted lines

> >  		} else if (cache_name_pos(src, length) < 0)
> >  			bad = _("not under version control");
> > -		else if (lstat(dst, &st) == 0) {
> > +		else if (lstat(dst, &dst_st) == 0 &&
> > +			 (src_st.st_ino != dst_st.st_ino ||
> > +			  (src_st.st_ino == 0 && strcasecmp(src, dst)))) {
> 
> Don't do that. st_ino is zero on Windows only because we do not spend time
> to fill in the field. Don't use it as an indicator for a case-insensitive
> file system; zero may be a valid inode number on other systems.

I don't think it is a problem if zero is a valid inode. The only thing that happens when there is a zero inode, is that we have to compare filenames. The inode check is just an optimization to avoid doing a bunch of strcasecmp on systems that don't have to.