Re: [RFC/PATCH 4/4] replace: add --edit option

From: Jeff King <peff@peff.net>
Date: Mar 7, 2014, 17:17 UTC
Message-ID: <20140307171714.GB23587@sigill.intra.peff.net>
In-Reply-To: <CAPig+cQi+7md4P2OXJDDcs7VMkMEsUHaEz5wsaDOyu4ppk2uAg@mail.gmail.com>

On Thu, Mar 06, 2014 at 08:57:58PM -0500, Eric Sunshine wrote:

Show 10 quoted lines

> > +               if (strbuf_read(&result, cmd.out, 41) < 0)
> > +                       die_errno("unable to read from mktree");
> > +               close(cmd.out);
> > +
> > +               if (finish_command(&cmd))
> > +                       die("mktree reported failure");
> > +               if (get_sha1_hex(result.buf, sha1) < 0)
> > +                       die("mktree did not return an object name");
> 
> strbuf_release(&result);

Thanks for catching. I'll include it in any re-roll.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.