[RFC/PATCH 1/4] replace: refactor command-mode determination
- From
Jeff King <peff@peff.net>
- Date
- Mar 6, 2014, 17:49 UTC
- Message-ID
- <20140306174904.GA30691@sigill.intra.peff.net>
- In-Reply-To
- <20140306174803.GA30486@sigill.intra.peff.net>
The git-replace command has three modes: listing, deleting, and replacing. The first two are selected explicitly. If none is selected, we fallback to listing when there are no arguments, and replacing otherwise.
Let's figure out up front which operation we are going to do, before getting into the application logic. That lets us simplify our option checks (e.g., we currently have to check whether a useless "--force" is given both along with an explicit list, as well as with an implicit one).
This saves some lines, makes the logic easier to follow, and will facilitate further cleanups.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/replace.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/builtin/replace.c b/builtin/replace.c index 2336325..6a0e8bd 100644 --- a/builtin/replace.c +++ b/builtin/replace.c @@ -182,12 +182,16 @@ int cmd_replace(int argc, const char **argv, const char *prefix) argc = parse_options(argc, argv, prefix, options, git_replace_usage, 0); + if (!list && !delete) + if (!argc) + list = 1; + if (list && delete) usage_msg_opt("-l and -d cannot be used together", git_replace_usage, options); - if (format && delete) - usage_msg_opt("--format and -d cannot be used together", + if (format && !list) + usage_msg_opt("--format cannot be used when not listing", git_replace_usage, options); if (force && (list || delete)) @@ -207,9 +211,6 @@ int cmd_replace(int argc, const char **argv, const char *prefix) if (argc != 2) usage_msg_opt("bad number of arguments", git_replace_usage, options); - if (format) - usage_msg_opt("--format cannot be used when not listing", - git_replace_usage, options); return replace_object(argv[0], argv[1], force); } @@ -217,9 +218,6 @@ int cmd_replace(int argc, const char **argv, const char *prefix) if (argc > 1) usage_msg_opt("only one pattern can be given with -l", git_replace_usage, options); - if (force) - usage_msg_opt("-f needs some arguments", - git_replace_usage, options); return list_replace_refs(argv[0], format); }
-- 1.8.5.2.500.g8060133