Re: [PATCH] disable grafts during fetch/push/bundle

From: Philip Oakley <philipoakley@iee.org>
Date: Mar 6, 2014, 23:39 UTC
Message-ID: <06EAF31C54FB49E5951781E637A79F04@PhilipOakley>
In-Reply-To: <531904E1.6010606@alum.mit.edu>

From: "Michael Haggerty" <mhagger@alum.mit.edu>

Show 29 quoted lines

> On 03/07/2014 12:01 AM, Philip Oakley wrote:
>> From: "Jeff King" <peff@peff.net>
>>> On Thu, Mar 06, 2014 at 05:41:27PM +0100, Michael Haggerty wrote:
>>>
>>>> > We can wrap that in "git replace --convert-grafts", but I do not 
>>>> >  >
>>>> think
>>>> > grafts are so common that there would be a big demand for it.
>>>>
>>>> It's probably easier to wrap it than to explain to Windows users 
>>>> what
>>>> they have to do.
>>>
>>> How would Windows users get a graft file in the first-place? There's 
>>> no
>>> GUI for it! ;)
>>
>> Now, now... It's dead easy using the git-gui and Notepad++, you can 
>> see
>> and confirm the sha1's, copy and paste, and the graft file is a very
>> easy format, so even wimps (windows, icons, menus, pointers aka 
>> mouse)
>> folks can do it. (It worked for me when I needed it ;-)
>
> I didn't mean to insult all Windows users in general.  I was only
> referring to the fact that since the default Windows command line is 
> not
> a POSIX shell, even an experienced Windows user might have trouble
> figuring out how to execute a shell loop.

I'd missed that aspect about the shell loop. I was mainly pointing out current awkwardness of creating the replace object, relative to grafts - There was an initial attempt by Christian, but it became quite hard to make it robust to sha1's embedded in commit messages.

Show 12 quoted lines

>      Putting this functionality in
> a git command or script, by contrast, would make it work universally, 
> no
> fuss, no muss.
>
> Michael
>
> -- 
> Michael Haggerty
> mhagger@alum.mit.edu
> http://softwareswirl.blogspot.com/
>