Re: [PATCH] disable grafts during fetch/push/bundle

From: Jeff King <peff@peff.net>
Date: Mar 5, 2014, 01:05 UTC
Message-ID: <20140305010529.GA11923@sigill.intra.peff.net>
In-Reply-To: <CAPig+cRqyG_JXSO-DsdP0mAjfmgS+FUCxLz+0+rHeUXrjmcjJg@mail.gmail.com>

On Tue, Mar 04, 2014 at 08:00:44PM -0500, Eric Sunshine wrote:

Show 13 quoted lines

> >> > +int commit_grafts_loaded(void)
> >> > +{
> >> > +       return !!commit_graft_nr;
> >> > +}
> >>
> >> Did you mean !!commit_graft ?
> >
> > Shouldn't they produce the same results?
> 
> Yes they should, but the use of !! seemed to imply that you wanted to
> apply it to the pointer value. (If you indeed intended to use
> commit_graft_nr, then 'return commit_graft_nr', without !!, would have
> been sufficient and idiomatic C.)

I just wanted to normalize the return value to a boolean 0/1. Even when the input is an int, it eliminates surprises when you try to assign the result to a bitfield or other smaller-width type.

-Peff