git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs

From
Jeff King <peff@peff.net>
Date
May 6, 2013, 16:40 UTC
Message-ID
<20130506164046.GA20257@sigill.intra.peff.net>
In-Reply-To
<7vli7srrva.fsf@alter.siamese.dyndns.org>
On Mon, May 06, 2013 at 09:32:41AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> > OK. If the argument is "we do not write them, so do not bother reading
> > them back in", I think that is reasonable.
> 
> The way I read builtin/fast-export.c::import_marks() is that it is
> more like "we do not write them, and we do not read them back in
> either IN THE CURRENT CODE".

Ahh...I see now. It is not about skipping the blobs as a new behavior, but rather about skipping them _earlier_, before we have loaded the object contents from disk.

I took the "we don't care about" as "the general use of fast-export does not care about", but it is "we will literally just drop them a few lines later".

So yes, I think this is an obviously correct optimization. Thanks for clarifying, and sorry to be so slow.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 25 in “fast-export: speed improvements”
  1. 0/3 fast-export: speed improvementsFelipe Contreras, May 5, 2013
  2. 1/3 fast-{import,export}: use get_sha1_hex() directlyFelipe Contreras, May 5, 2013
  3. Junio C HamanoMay 7, 2013
  4. Felipe ContrerasMay 7, 2013
  5. Junio C HamanoMay 7, 2013
  6. 2/3 fast-export: improve speed by skipping blobsFelipe Contreras, May 5, 2013
  7. Jeff KingMay 6, 2013
  8. Junio C HamanoMay 6, 2013
  9. Junio C HamanoMay 6, 2013
  10. Jeff KingMay 6, 2013
  11. Junio C HamanoMay 6, 2013
  12. Jeff KingMay 6, 2013
  13. Junio C HamanoMay 6, 2013
  14. Jeff KingMay 6, 2013
  15. Jeff KingMay 6, 2013
  16. Felipe ContrerasMay 6, 2013
  17. Felipe ContrerasMay 6, 2013
  18. Junio C HamanoMay 6, 2013
  19. Felipe ContrerasMay 6, 2013
  20. Junio C HamanoMay 7, 2013
  21. Felipe ContrerasMay 7, 2013
  22. Felipe ContrerasMay 6, 2013
  23. Jeff KingMay 6, 2013
  24. Felipe ContrerasMay 6, 2013
  25. 3/3 fast-export: don't parse all the commitsFelipe Contreras, May 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.