Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs

From: Jeff King <peff@peff.net>
Date: May 6, 2013, 19:11 UTC
Message-ID: <20130506191146.GA3056@sigill.intra.peff.net>
In-Reply-To: <CAMP44s2rvu2PaazHEx-OXaZbuBAX7sZb04Oh38ifyAEG6kcxkw@mail.gmail.com>

On Mon, May 06, 2013 at 02:02:13PM -0500, Felipe Contreras wrote:

Show 7 quoted lines

> > I did a double-take on reading this subject line and first paragraph,
> > thinking "surely fast-export needs to actually output blobs?".
> 
> If you think that, then you are not familiar with the code.
> 
> --export-marks=<file>::
> [...]

My point was that nothing in the subject line nor that first paragraph (nor, for that matter, the entire commit message) says that we are talking about marks here.

Show 5 quoted lines

> > Reading the patch, I see that this is only about not bothering to load
> > blob marks from --import-marks. It might be nice to mention that in the
> > commit message, which is otherwise quite confusing.
> 
> The commit message says it exactly like it is: we don't care about blobs.

If you guess that "we" means the marks code and not all of fast-export, then yes. But I do not have any desire to get into another debate trying to convince you that there is value to having a clear commit message. Junio has already proposed a much more readable one.

-Peff