From: Jeff King <peff@peff.net>
Date: Mon, 06 May 2013 16:40:46 GMT
Subject: Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs
Message-ID: <20130506164046.GA20257@sigill.intra.peff.net>
In-Reply-To: <7vli7srrva.fsf@alter.siamese.dyndns.org>

On Mon, May 06, 2013 at 09:32:41AM -0700, Junio C Hamano wrote:

> > OK. If the argument is "we do not write them, so do not bother reading
> > them back in", I think that is reasonable.
> 
> The way I read builtin/fast-export.c::import_marks() is that it is
> more like "we do not write them, and we do not read them back in
> either IN THE CURRENT CODE".

Ahh...I see now. It is not about skipping the blobs as a new behavior,
but rather about skipping them _earlier_, before we have loaded the
object contents from disk.

I took the "we don't care about" as "the general use of fast-export does
not care about", but it is "we will literally just drop them a few lines
later".

So yes, I think this is an obviously correct optimization. Thanks for
clarifying, and sorry to be so slow.

-Peff