Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2013, 16:32 UTC
Message-ID: <7vli7srrva.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130506162008.GB7992@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Mon, May 06, 2013 at 08:08:45AM -0700, Junio C Hamano wrote:
>
>> > I'm also not sure why your claim "we don't care about blobs" is true,
>> > because naively we would want future runs of fast-export to avoid having
>> > to write out the whole blob content when mentioning the blob again.
>> 
>> The existing documentation is fairly clear that marks for objects
>> other than commits are not exported, and the import-marks codepath
>> discards anything but commits, so there is no mechanism for the
>> existing fast-export users to leave blob marks in the marks file for
>> later runs of fast-export to take advantage of.  The second
>> invocation cannot refer to such a blob in the first place.
>
> OK. If the argument is "we do not write them, so do not bother reading
> them back in", I think that is reasonable.

The way I read builtin/fast-export.c::import_marks() is that it is more like "we do not write them, and we do not read them back in either IN THE CURRENT CODE".