Re: [PATCH 4/4] transport: drop "int cmp = cmp" hack
- From
Jeff King <peff@peff.net>
- Date
- Mar 24, 2013, 09:32 UTC
- Message-ID
- <20130324093212.GA28234@sigill.intra.peff.net>
- In-Reply-To
- <CAPc5daVOksx56js_ascEr348PTLAZB9OeBrf3sELJUpdyB_kMg@mail.gmail.com>
On Sat, Mar 23, 2013 at 09:00:05PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> On Thu, Mar 21, 2013 at 4:13 AM, Jeff King <peff@peff.net> wrote: > > > > According to 47ec794, this initialization is meant to > > squelch an erroneous uninitialized variable warning from gcc > > 4.0.1. That version is quite old at this point, and gcc 4.1 > > and up handle it fine, with one exception. There seems to be > > a regression in gcc 4.6.3, which produces the warning; > > however, gcc versions 4.4.7 and 4.7.2 do not. > > > > transport.c: In function 'get_refs_via_rsync': > transport.c:127:29: error: 'cmp' may be used uninitialized in this > function [-Werror=uninitialized] > transport.c:109:7: note: 'cmp' was declared here > > gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
Right, that's the same version I noted above. Is 4.6.3 the default compiler under a particular release of Ubuntu, or did you use their gcc-4.6 package?
-Peff