Re: [PATCH 1/4] wt-status: fix possible use of uninitialized variable

From: Jeff King <peff@peff.net>
Date: Mar 22, 2013, 16:15 UTC
Message-ID: <20130322161540.GF3083@sigill.intra.peff.net>
In-Reply-To: <20130321194949.GG29311@google.com>

On Thu, Mar 21, 2013 at 12:49:50PM -0700, Jonathan Nieder wrote:

> > We could also convert the flag to an enum, which would
> > provide a compile-time check on the function input.
> 
> Unfortunately C permits out-of-bounds values for enums.

True, although I would think that most compilers take the hint for switch() statements that handling all defined constants for an enum is enough (certainly gcc does it with the "some enum constants not handled" warning, but I did not actually check whether it does so in the uninitialized-warning control flow checker).

Still, I'm happy enough with the die("BUG") that I posted, so we don't need to worry about it.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.