[PATCH 4/4] transport: drop "int cmp = cmp" hack
- From
Jeff King <peff@peff.net>
- Date
- Mar 21, 2013, 11:13 UTC
- Message-ID
- <20130321111333.GD18819@sigill.intra.peff.net>
- In-Reply-To
- <20130321110338.GA18552@sigill.intra.peff.net>
According to 47ec794, this initialization is meant to squelch an erroneous uninitialized variable warning from gcc 4.0.1. That version is quite old at this point, and gcc 4.1 and up handle it fine, with one exception. There seems to be a regression in gcc 4.6.3, which produces the warning; however, gcc versions 4.4.7 and 4.7.2 do not.
Signed-off-by: Jeff King <peff@peff.net> --- We probably _don't_ want to apply this one right now. The regression in 4.6 means some people on reasonably modern systems probably would still see the warning. Debian stable ships with 4.4, and testing/unstable defaults to 4.7 (though you can install a gcc-4.6 compatibility package). But I have no clue if other distros made releases with 4.6.
transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport.c b/transport.c index 886ffd8..87b8f14 100644 --- a/transport.c +++ b/transport.c @@ -106,7 +106,7 @@ static void insert_packed_refs(const char *packed_refs, struct ref **list) return; for (;;) { - int cmp = cmp, len; + int cmp, len; if (!fgets(buffer, sizeof(buffer), f)) { fclose(f);
-- 1.8.2.rc2.8.g2161951