git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

From
Jeff King <peff@peff.net>
Date
Aug 7, 2012, 04:03 UTC
Message-ID
<20120807040326.GA18682@sigill.intra.peff.net>
In-Reply-To
<7v4nofxt89.fsf@alter.siamese.dyndns.org>
On Mon, Aug 06, 2012 at 08:43:02PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Ben Walton <bwalton@artsci.utoronto.ca> writes:
> 
> > Now that git_terminal_prompt can cleanly interact with /dev/tty on
> > Solaris, enable HAVE_DEV_TTY so that this code path is used for
> > credential reading instead of relying on the crippled getpass().
> >
> > Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> > ---
> >
> > This is a follow up to Jeff's patch that fixes git_terminal_prompt on
> > Solaris.  I don't have 5.6 or 5.7 for testing but I believe this
> > should be valid for both of those releases as well.
> 
> So which direction do you guys want to go?  Use the "bidirectional
> stdio with fseek()" for now, with the expectation that Tay's other
> series will rewrite it to fd based one?

I think so. The stdio fix is short and obviously correct, and then Tay can either refactor or not as he sees fit for his topic (although if we do switch to just a terminal_can_prompt() interface and get rid of the term_t ugliness, then there is not even any need to do the rewrite).

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 23 of 27 in “Avoid crippled getpass function on Solaris”
  1. Avoid crippled getpass function on SolarisBen Walton, Aug 5, 2012
  2. Tay Ray ChuanAug 6, 2012
  3. Ben WaltonAug 6, 2012
  4. Junio C HamanoAug 6, 2012
  5. Ben WaltonAug 6, 2012
  6. Jeff KingAug 6, 2012
  7. Junio C HamanoAug 6, 2012
  8. Ben WaltonAug 6, 2012
  9. Jeff KingAug 6, 2012
  10. Ben WaltonAug 6, 2012
  11. Jeff KingAug 6, 2012
  12. Ben WaltonAug 6, 2012
  13. Jeff KingAug 6, 2012
  14. Ben WaltonAug 6, 2012
  15. Jeff KingAug 7, 2012
  16. Andreas SchwabAug 6, 2012
  17. Jeff KingAug 7, 2012
  18. Jeff KingAug 7, 2012
  19. Tay Ray ChuanAug 7, 2012
  20. Ben WaltonAug 7, 2012
  21. Enable HAVE_DEV_TTY for SolarisBen Walton, Aug 7, 2012
  22. Junio C HamanoAug 7, 2012
  23. Jeff KingAug 7, 2012
  24. Jeff KingAug 7, 2012
  25. Ben WaltonAug 7, 2012
  26. Erik Faye-LundAug 8, 2012
  27. Jeff KingAug 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.