[PATCH] Avoid crippled getpass function on Solaris

On Solaris getpass() returns at most 8 characters which cripples the credential reading for accounts using longer passwords. The alternate function getpassphrase() was introduced in SunOS 5.6 and will return up to 256 characters.

Ensure that git_terminal_prompt uses the more able function when building on Solaris.

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---

Hi Jeff and Junio,

I considered making this minor change a few different ways but settled on this as it seemed (to my eye) to most closely adhere to the way other such things were done in the compatibility code. I'm entirely open to modifying this if it's felt that there is a clearer/cleaner way to do it.

I'd even considered making the function swap generic enough to be driven by the build system. That seemed over the top though, given that most systems either have a decent getpass() or don't use this code path at all.

I've also briefly dabbled with getting Solaris to simply use the HAVE_DEV_TTY code path but the terminal echo stuff hasn't worked nicely for me just yet. (It reads the password with nothing echoed but then displays the string after reading the newline.) This might still be a better approach in the future, but for now, having long password reading capability will still be a benefit to users on this platform.

Thanks -Ben

 compat/terminal.c |    2 +-
 compat/terminal.h |    9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)