From: Jeff King Date: Tue, 07 Aug 2012 04:03:26 GMT Subject: Re: [PATCH] Enable HAVE_DEV_TTY for Solaris Message-ID: <20120807040326.GA18682@sigill.intra.peff.net> In-Reply-To: <7v4nofxt89.fsf@alter.siamese.dyndns.org> On Mon, Aug 06, 2012 at 08:43:02PM -0700, Junio C Hamano wrote: > Ben Walton writes: > > > Now that git_terminal_prompt can cleanly interact with /dev/tty on > > Solaris, enable HAVE_DEV_TTY so that this code path is used for > > credential reading instead of relying on the crippled getpass(). > > > > Signed-off-by: Ben Walton > > --- > > > > This is a follow up to Jeff's patch that fixes git_terminal_prompt on > > Solaris. I don't have 5.6 or 5.7 for testing but I believe this > > should be valid for both of those releases as well. > > So which direction do you guys want to go? Use the "bidirectional > stdio with fseek()" for now, with the expectation that Tay's other > series will rewrite it to fd based one? I think so. The stdio fix is short and obviously correct, and then Tay can either refactor or not as he sees fit for his topic (although if we do switch to just a terminal_can_prompt() interface and get rid of the term_t ugliness, then there is not even any need to do the rewrite). -Peff