git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 7, 2012, 03:43 UTC
Message-ID
<7v4nofxt89.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1344308862-24635-1-git-send-email-bwalton@artsci.utoronto.ca>
Ben Walton <bwalton@artsci.utoronto.ca> writes:
Show 10 quoted lines
> Now that git_terminal_prompt can cleanly interact with /dev/tty on
> Solaris, enable HAVE_DEV_TTY so that this code path is used for
> credential reading instead of relying on the crippled getpass().
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> ---
>
> This is a follow up to Jeff's patch that fixes git_terminal_prompt on
> Solaris.  I don't have 5.6 or 5.7 for testing but I believe this
> should be valid for both of those releases as well.

So which direction do you guys want to go? Use the "bidirectional stdio with fseek()" for now, with the expectation that Tay's other series will rewrite it to fd based one?

Show 16 quoted lines
>
>  Makefile |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 15d1319..6b0c961 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1014,6 +1014,7 @@ ifeq ($(uname_S),SunOS)
>  	NO_REGEX = YesPlease
>  	NO_FNMATCH_CASEFOLD = YesPlease
>  	NO_MSGFMT_EXTENDED_OPTIONS = YesPlease
> +	HAVE_DEV_TTY = YesPlease
>  	ifeq ($(uname_R),5.6)
>  		SOCKLEN_T = int
>  		NO_HSTRERROR = YesPlease
Previous: Ben WaltonNext: Jeff King
Message 22 of 27 in “Avoid crippled getpass function on Solaris”
  1. Avoid crippled getpass function on SolarisBen Walton, Aug 5, 2012
  2. Tay Ray ChuanAug 6, 2012
  3. Ben WaltonAug 6, 2012
  4. Junio C HamanoAug 6, 2012
  5. Ben WaltonAug 6, 2012
  6. Jeff KingAug 6, 2012
  7. Junio C HamanoAug 6, 2012
  8. Ben WaltonAug 6, 2012
  9. Jeff KingAug 6, 2012
  10. Ben WaltonAug 6, 2012
  11. Jeff KingAug 6, 2012
  12. Ben WaltonAug 6, 2012
  13. Jeff KingAug 6, 2012
  14. Ben WaltonAug 6, 2012
  15. Jeff KingAug 7, 2012
  16. Andreas SchwabAug 6, 2012
  17. Jeff KingAug 7, 2012
  18. Jeff KingAug 7, 2012
  19. Tay Ray ChuanAug 7, 2012
  20. Ben WaltonAug 7, 2012
  21. Enable HAVE_DEV_TTY for SolarisBen Walton, Aug 7, 2012
  22. Junio C HamanoAug 7, 2012
  23. Jeff KingAug 7, 2012
  24. Jeff KingAug 7, 2012
  25. Ben WaltonAug 7, 2012
  26. Erik Faye-LundAug 8, 2012
  27. Jeff KingAug 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.