Re: [PATCH 1/3] retain reflogs for deleted refs
- From
Jeff King <peff@peff.net>
- Date
- Jul 26, 2012, 17:52 UTC
- Message-ID
- <20120726175248.GA15928@sigill.intra.peff.net>
- In-Reply-To
- <7vehny8lgm.fsf@alter.siamese.dyndns.org>
On Thu, Jul 26, 2012 at 10:46:01AM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> > Bleh. It seems that we did too good a job in coming up with a list of > > disallowed ref characters; they really are things you don't want in your > > filenames at all. :) > > Why do no need to even worry about ~ vs : vs whatever in the first > place? > > With a flag-day per repository "core.repositoryformatversion = 1", > you do not have to worry about mixture of old-style refs and new > ones, so refs/heads/next-d/log could be a topic branch 'next/log' > that is based on an integration branch 'next' branch that physically > resides at refs/heads/next-f or an entry refs/heads/next in packed > refs. Only the API functions in refs.c should care, no?
I think the point was that Michael wanted to select a standard that could be used for graveyard reflogs _now_, but which would eventually match the format we use for active refs. And that requires a character that is not valid in a refname.
Given that the change of format for actives refs would require a flag day, keeping the graveyard scheme mixable with the current ref rules may not be worth caring about, though.
-Peff