git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout: default to quiet if !isatty(2).

From
Jeff King <peff@peff.net>
Date
May 24, 2012, 06:10 UTC
Message-ID
<20120524061000.GA14035@sigill.intra.peff.net>
In-Reply-To
<1337839534-7760-1-git-send-email-apenwarr@gmail.com>
On Thu, May 24, 2012 at 02:05:34AM -0400, Avery Pennarun wrote:
> It would probably be better to have progress.c check isatty(2) all the time,
> but that wouldn't allow things like 'git push --progress' to force progress
> reporting to on, so I won't try to solve the general case right now.

This looks better. There is a slight inaccuracy in your subject line, though. We are not defaulting to quiet if !isatty(2) in all cases, but rather only when we call into unpack_trees, which generates the progress output. We will still print the ahead/behind line, detached HEAD info, etc.

Which I think is the right behavior, but is not quite what is advertised by your commit message.

-Peff
Previous: Avery PennarunNext: Avery Pennarun
Message 4 of 11 in “progress: don't print if !isatty(2).”
  1. progress: don't print if !isatty(2).Avery Pennarun, May 24, 2012
  2. Jeff KingMay 24, 2012
  3. checkout: default to quiet if !isatty(2).Avery Pennarun, May 24, 2012
  4. Jeff KingMay 24, 2012
  5. checkout: no progress messages if !isatty(2).Avery Pennarun, May 24, 2012
  6. Junio C HamanoMay 24, 2012
  7. Jeff KingMay 24, 2012
  8. Avery PennarunMay 24, 2012
  9. Avery PennarunMay 24, 2012
  10. Junio C HamanoMay 24, 2012
  11. Avery PennarunMay 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.