From: Jeff King <peff@peff.net>
Date: Thu, 24 May 2012 06:10:00 GMT
Subject: Re: [PATCH] checkout: default to quiet if !isatty(2).
Message-ID: <20120524061000.GA14035@sigill.intra.peff.net>
In-Reply-To: <1337839534-7760-1-git-send-email-apenwarr@gmail.com>

On Thu, May 24, 2012 at 02:05:34AM -0400, Avery Pennarun wrote:

> It would probably be better to have progress.c check isatty(2) all the time,
> but that wouldn't allow things like 'git push --progress' to force progress
> reporting to on, so I won't try to solve the general case right now.

This looks better. There is a slight inaccuracy in your subject line,
though. We are not defaulting to quiet if !isatty(2) in all cases, but
rather only when we call into unpack_trees, which generates the progress
output. We will still print the ahead/behind line, detached HEAD info,
etc.

Which I think is the right behavior, but is not quite what is advertised
by your commit message.

-Peff