Re: [PATCH v2] checkout: no progress messages if !isatty(2).

From: Junio C Hamano <gitster@pobox.com>
Date: May 24, 2012, 18:29 UTC
Message-ID: <7vy5ohwhy7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1337839944-4651-1-git-send-email-apenwarr@gmail.com>

Avery Pennarun <apenwarr@gmail.com> writes:

> It would probably be better to have progress.c check isatty(2) all the time,
> but that wouldn't allow things like 'git push --progress' to force progress
> reporting to on, so I won't try to solve the general case right now.

Before that "It would probably be better" comment to give your opinion, you need to describe what problem you wanted to solve in the first place. I'll lift it from your original version of the patch:

    If stderr isn't a tty, we shouldn't be printing incremental progress
    messages.  In particular, this affected 'git checkout -f . >&logfile'
    unless you provided -q.  And git-new-workdir has no way to provide -q.

I do not seem to find a sane justification for

	git $cmd --progress 2>output

use case and I do not immediately see how that "output" file can be useful. But we've allowed it for a long time, so probably this version is safer. Besides, it is more explicit.

Thanks.