git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] completion: trivial cleanups and fixes

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 15, 2012, 13:20 UTC
Message-ID
<20120415132002.GB2544@burratino>
In-Reply-To
<1334439784-6460-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras wrote:
> Just a few simpliciations, improvements, and add some missing options.
I generally like this.  Quick comments:
> Felipe Contreras (3):
>   completion: simplify __gitcomp_1

Thomas and Gábor seem to have this one covered, with some improvements to it under discussion.

>   completion: trivial simplification

Improves consistency. The changelog line isn't precise enough to remind me which change is being mentioned when reading it in the shortlog, so I guess I'd prefer something like

	completion: simplify by using $prev variable
>   completion: add missing general options

Likewise, a subject line like the following would work better for me.

	completion: --info-path and --no-replace-objects options for git

Hope that helps, Jonathan

Previous: Felipe ContrerasNext: Felipe Contreras
Message 14 of 15 in “completion: trivial cleanups and fixes”
  1. 0/5 completion: trivial cleanups and fixesFelipe Contreras, Apr 14, 2012
  2. 1/5 completion: simplify __gitcomp_1Felipe Contreras, Apr 14, 2012
  3. Thomas RastApr 14, 2012
  4. Felipe ContrerasApr 14, 2012
  5. Felipe ContrerasApr 15, 2012
  6. Andreas SchwabApr 15, 2012
  7. SZEDER GáborApr 15, 2012
  8. Andreas SchwabApr 15, 2012
  9. SZEDER GáborApr 15, 2012
  10. 2/5 completion: trivial simplificationFelipe Contreras, Apr 14, 2012
  11. 3/5 completion: add missing general optionsFelipe Contreras, Apr 14, 2012
  12. 4/5 completion: avoid trailing space for --exec-pathFelipe Contreras, Apr 14, 2012
  13. 5/5 completion: fix completion after 'git --option <TAB>'Felipe Contreras, Apr 14, 2012
  14. Jonathan NiederApr 15, 2012
  15. Felipe ContrerasApr 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.