git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/5] completion: simplify __gitcomp_1

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 14, 2012, 21:43 UTC
Message-ID
<1334439784-6460-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1334439784-6460-1-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..13be9a7 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -307,13 +307,13 @@ __git_ps1 ()
 # __gitcomp_1 requires 2 arguments
 __gitcomp_1 ()
 {
-	local c IFS=' '$'\t'$'\n'
+	local c s IFS=' '$'\t'$'\n'
 	for c in $1; do
 		case "$c$2" in
-		--*=*) printf %s$'\n' "$c$2" ;;
-		*.)    printf %s$'\n' "$c$2" ;;
-		*)     printf %s$'\n' "$c$2 " ;;
+		--*=* | *.) s="" ;;
+		*)          s=" " ;;
 		esac
+		echo "$c$2$s"
 	done
 }
 
-- 
1.7.10.1.g1f19b8.dirty
Previous: Felipe ContrerasNext: Thomas Rast
Message 2 of 15 in “completion: trivial cleanups and fixes”
  1. 0/5 completion: trivial cleanups and fixesFelipe Contreras, Apr 14, 2012
  2. 1/5 completion: simplify __gitcomp_1Felipe Contreras, Apr 14, 2012
  3. Thomas RastApr 14, 2012
  4. Felipe ContrerasApr 14, 2012
  5. Felipe ContrerasApr 15, 2012
  6. Andreas SchwabApr 15, 2012
  7. SZEDER GáborApr 15, 2012
  8. Andreas SchwabApr 15, 2012
  9. SZEDER GáborApr 15, 2012
  10. 2/5 completion: trivial simplificationFelipe Contreras, Apr 14, 2012
  11. 3/5 completion: add missing general optionsFelipe Contreras, Apr 14, 2012
  12. 4/5 completion: avoid trailing space for --exec-pathFelipe Contreras, Apr 14, 2012
  13. 5/5 completion: fix completion after 'git --option <TAB>'Felipe Contreras, Apr 14, 2012
  14. Jonathan NiederApr 15, 2012
  15. Felipe ContrerasApr 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.