git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/5] completion: simplify __gitcomp_1

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Apr 15, 2012, 09:33 UTC
Message-ID
<20120415093334.GB2900@goldbirke>
In-Reply-To
<m2ehrpcs9u.fsf@linux-m68k.org>
On Sun, Apr 15, 2012 at 10:29:17AM +0200, Andreas Schwab wrote:
Show 31 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > However, I would like to simplify it even more:
> >
> > __gitcomp_1 ()
> > {
> > 	local c w s IFS=' '$'\t'$'\n'
> > 	for c in $1; do
> > 		w="$c$2"
> > 		case "$w" in
> > 		--*=*|*.) s="" ;;
> > 		*)        s=" " ;;
> > 		esac
> > 		printf "%s$s\n" "$w"
> > 	done
> > }
> 
> Or even:
> 
> __gitcomp_1 ()
> {
> 	local c IFS=$' \t\n'
> 	for c in $1; do
> 		c=$c$2
> 		case $c in
> 		--*=*|*.) ;;
> 		*)        c="$c " ;;
> 		esac
> 		printf '%s\n' "$c"
> 	done
> }
We can even get rid of the %s with
  printf -- "$c\n"
Previous: Andreas SchwabNext: Andreas Schwab
Message 7 of 15 in “completion: trivial cleanups and fixes”
  1. 0/5 completion: trivial cleanups and fixesFelipe Contreras, Apr 14, 2012
  2. 1/5 completion: simplify __gitcomp_1Felipe Contreras, Apr 14, 2012
  3. Thomas RastApr 14, 2012
  4. Felipe ContrerasApr 14, 2012
  5. Felipe ContrerasApr 15, 2012
  6. Andreas SchwabApr 15, 2012
  7. SZEDER GáborApr 15, 2012
  8. Andreas SchwabApr 15, 2012
  9. SZEDER GáborApr 15, 2012
  10. 2/5 completion: trivial simplificationFelipe Contreras, Apr 14, 2012
  11. 3/5 completion: add missing general optionsFelipe Contreras, Apr 14, 2012
  12. 4/5 completion: avoid trailing space for --exec-pathFelipe Contreras, Apr 14, 2012
  13. 5/5 completion: fix completion after 'git --option <TAB>'Felipe Contreras, Apr 14, 2012
  14. Jonathan NiederApr 15, 2012
  15. Felipe ContrerasApr 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.