From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 15 Apr 2012 13:20:02 GMT
Subject: Re: [PATCH v3 0/5] completion: trivial cleanups and fixes
Message-ID: <20120415132002.GB2544@burratino>
In-Reply-To: <1334439784-6460-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:

> Just a few simpliciations, improvements, and add some missing options.

I generally like this.  Quick comments:

> Felipe Contreras (3):
>   completion: simplify __gitcomp_1

Thomas and Gábor seem to have this one covered, with some improvements
to it under discussion.

>   completion: trivial simplification

Improves consistency.  The changelog line isn't precise enough to
remind me which change is being mentioned when reading it in the
shortlog, so I guess I'd prefer something like

	completion: simplify by using $prev variable

>   completion: add missing general options

Likewise, a subject line like the following would work better for
me.

	completion: --info-path and --no-replace-objects options for git

Hope that helps,
Jonathan