From: SZEDER Gábor <szeder@ira.uka.de>
Date: Sun, 15 Apr 2012 09:33:34 GMT
Subject: Re: [PATCH v3 1/5] completion: simplify __gitcomp_1
Message-ID: <20120415093334.GB2900@goldbirke>
In-Reply-To: <m2ehrpcs9u.fsf@linux-m68k.org>

On Sun, Apr 15, 2012 at 10:29:17AM +0200, Andreas Schwab wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > However, I would like to simplify it even more:
> >
> > __gitcomp_1 ()
> > {
> > 	local c w s IFS=' '$'\t'$'\n'
> > 	for c in $1; do
> > 		w="$c$2"
> > 		case "$w" in
> > 		--*=*|*.) s="" ;;
> > 		*)        s=" " ;;
> > 		esac
> > 		printf "%s$s\n" "$w"
> > 	done
> > }
> 
> Or even:
> 
> __gitcomp_1 ()
> {
> 	local c IFS=$' \t\n'
> 	for c in $1; do
> 		c=$c$2
> 		case $c in
> 		--*=*|*.) ;;
> 		*)        c="$c " ;;
> 		esac
> 		printf '%s\n' "$c"
> 	done
> }

We can even get rid of the %s with

  printf -- "$c\n"