git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 14, 2012, 19:55 UTC
Message-ID
<20120314195509.GA31686@burratino>
In-Reply-To
<20120314233609.04a2a37b@zappedws>
Alexey Shumkin wrote:
Show 6 quoted lines
> I'd like to remind then following aspect
>
>> My proposition was in to send email message in explicitly defined
>> custom encoding. Why? In development process under Windows non-UTF-8
>> encoding is used (cp1251 in my case). So, filenames have this
>> encoding, and as we know Git stores their names as is
[...]
>>                                                                 with
>> core.quotepath= false

Sure. Do you think this patch makes that problem worse, and if so, do you have any ideas about how that could be prevented? Otherwise:

>>            Making the email charset configurable is left as an
>> exercise for the interested reader.

I did not want to do that part because I do not trust myself to understand the needs of people using non-utf8 and test it appropriately, but I tried to make sure the patch was structured in a way that would make it easy.

Hoping clarifies a little, Jonathan

Previous: Alexey ShumkinNext: Junio C Hamano
Message 7 of 9 in “post-receive-email: declaring and consistently using one output encoding”
  1. 0/2 post-receive-email: declaring and consistently using one output encodingJonathan Nieder, Mar 8, 2012
  2. 1/2 hooks/post-receive-email: set encoding to utf-8Jonathan Nieder, Mar 8, 2012
  3. 2/2 post-receive-email: defend against non UTF-8 i18n.logoutputencoding settingJonathan Nieder, Mar 8, 2012
  4. Jeff KingMar 8, 2012
  5. Jonathan NiederMar 8, 2012
  6. Alexey ShumkinMar 14, 2012
  7. Jonathan NiederMar 14, 2012
  8. Junio C HamanoMar 8, 2012
  9. Jon JensenMar 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.