From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 14 Mar 2012 19:55:09 GMT
Subject: Re: [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting
Message-ID: <20120314195509.GA31686@burratino>
In-Reply-To: <20120314233609.04a2a37b@zappedws>

Alexey Shumkin wrote:

> I'd like to remind then following aspect
>
>> My proposition was in to send email message in explicitly defined
>> custom encoding. Why? In development process under Windows non-UTF-8
>> encoding is used (cp1251 in my case). So, filenames have this
>> encoding, and as we know Git stores their names as is
[...]
>>                                                                 with
>> core.quotepath= false

Sure.  Do you think this patch makes that problem worse, and if so, do
you have any ideas about how that could be prevented?  Otherwise:

>>            Making the email charset configurable is left as an
>> exercise for the interested reader.

I did not want to do that part because I do not trust myself to
understand the needs of people using non-utf8 and test it
appropriately, but I tried to make sure the patch was structured in a
way that would make it easy.

Hoping clarifies a little,
Jonathan