Re: [PATCH 2/2] post-receive-email: defend against non UTF-8 i18n.logoutputencoding setting
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 8, 2012, 13:52 UTC
- Message-ID
- <20120308135237.GA14918@burratino>
- In-Reply-To
- <20120308135030.GB30602@sigill.intra.peff.net>
Jeff King wrote:
> If you are using "-s" to suppress diff output, why are you using > diff-tree? Wouldn't "rev-list -1" (or "rev-list --no-walk") work equally > well and be a little more obvious?
Just a habit --- some part of me is wired to think "diff-tree is the command to show a commit". Maybe rev-list didn't support --pretty in olden days?