Re: git push default behaviour?

From: Jeff King <peff@peff.net>
Date: Mar 9, 2012, 03:38 UTC
Message-ID: <20120309033826.GA6164@sigill.intra.peff.net>
In-Reply-To: <vpqfwdjas0m.fsf@bauges.imag.fr>

On Thu, Mar 08, 2012 at 07:04:25PM +0100, Matthieu Moy wrote:

Show 13 quoted lines

> Dmitry Potapov <dpotapov@gmail.com> writes:
> 
> > When you silently change
> > the default value of push, you silently break their workflow.
> 
> No one talked about changing it silently. Quoting myself:
> 
> | it needs to be done with a sane migration path, however
> 
> There is already a configuration variable, so it's easy to fix a default
> value change if you rely on it, but the first thing to do is to
> encourage people to explicitely set push.default, so that they are not
> affected by a potential future default change.

This is all sounding eerily familiar. Indeed:

  $ git log --oneline -Swarn_unconfigured_push -- builtin-push.c
  bba0fd2 push: do not give big warning when no preference is configured
  665d3e8 Display warning for default git push with no push.default config

I don't remember the mailing list conversations that surrounded those patches, but if we are going to have the same conversation again, maybe it is worth looking them up.

-Peff