Re: [PATCH] vcs-svn: Fix some compiler warnings
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 2, 2012, 18:53 UTC
- Message-ID
- <20120202185305.GB19520@burratino>
- In-Reply-To
- <4F2AD4CF.7020303@ramsay1.demon.co.uk>
Ramsay Jones wrote:
Show 6 quoted lines
> An static inline function was actually my first thought (although I had > something more like Junio's suggestion [elsewhere in this thread] in mind), > but I didn't want to place it in git-compat-util.h and could not find a > suitable place in the vcs-svn directory. > > Hmm, I will send a v2 patch along these lines ...
Well, your v2 patch looks good to me. The three-patch series I sent[1] also look good to me. I guess I could queue your v2 and put the rest on top --- what say you?
[1] http://thread.gmane.org/gmane.comp.version-control.git/189618 http://repo.or.cz/w/git/jrn.git/log/refs/topics/rj/svn-fe-type-limits