[PATCH/RFC 0/3] Re: [PATCH] vcs-svn: Fix some compiler warnings
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 2, 2012, 10:41 UTC
- Message-ID
- <20120202104128.GG3823@burratino>
- In-Reply-To
- <7vipjpzxav.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I'd hold the branch in 'next' for now, until this gets resolved (one > possible resolution is to declare Ramsey's patch is good enough for now, > and do the follow-up later).
Sounds sensible. How about the following? Intended to replace Ramsay's patch. Not well tested yet.
By the way, wouldn't the (p->field < 0) test in grep.c line 330 trigger the same compiler bug?
Jonathan Nieder (2): vcs-svn: allow import of > 4GiB files vcs-svn: suppress a -Wtype-limits warning
Ramsay Allan Jones (1): vcs-svn: rename check_overflow arguments for clarity
vcs-svn/fast_export.c | 15 +++++++++------ vcs-svn/fast_export.h | 4 ++-- vcs-svn/sliding_window.c | 10 +++++----- vcs-svn/svndump.c | 21 +++++++++++++++------ 4 files changed, 31 insertions(+), 19 deletions(-)