Re: [PATCH v3] gitk: Teach gitk to respect log.showroot
On Sat, Oct 08, 2011 at 05:47:04PM +1100, Paul Mackerras wrote:
Show 22 quoted lines
> On Tue, Oct 04, 2011 at 10:08:13PM +0200, Marcus Karlsson wrote:
> > Teach gitk to respect log.showroot.
>
> Sounds reasonable, ...
>
> > - set cmd [concat | git diff-tree -r $flags $ids]
> > + set cmd [concat | git diff-tree -r]
> > + if {$log_showroot eq true} {
> > + set cmd [concat $cmd --root]
> > + }
> > + set cmd [concat $cmd $flags $ids]
>
> but is there any reason not to do it like this?
>
> if {$log_showroot} {
> lappend flags --root
> }
> set cmd [concat | git diff-tree -r $flags $ids]
>
> I.e., do you particularly want the --root before the other flags?
>
> Paul.Not really, that would work very well.
Marcus