From: Marcus Karlsson <mk@acc.umu.se>
Date: Wed, 12 Oct 2011 14:36:39 GMT
Subject: Re: [PATCH v3] gitk: Teach gitk to respect log.showroot
Message-ID: <20111012143639.GA22316@kennedy.acc.umu.se>
In-Reply-To: <20111008064704.GA27056@bloggs.ozlabs.ibm.com>

On Sat, Oct 08, 2011 at 05:47:04PM +1100, Paul Mackerras wrote:
> On Tue, Oct 04, 2011 at 10:08:13PM +0200, Marcus Karlsson wrote:
> > Teach gitk to respect log.showroot.
> 
> Sounds reasonable, ...
> 
> > -	set cmd [concat | git diff-tree -r $flags $ids]
> > +	set cmd [concat | git diff-tree -r]
> > +	if {$log_showroot eq true} {
> > +	    set cmd [concat $cmd --root]
> > +	}
> > +	set cmd [concat $cmd $flags $ids]
> 
> but is there any reason not to do it like this?
> 
> 	if {$log_showroot} {
> 	    lappend flags --root
> 	}
> 	set cmd [concat | git diff-tree -r $flags $ids]
> 
> I.e., do you particularly want the --root before the other flags?
> 
> Paul.

Not really, that would work very well.

Marcus