Re: [PATCH v3] gitk: Teach gitk to respect log.showroot

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mar 19, 2012, 11:04 UTC
Message-ID: <4F6712DA.6090904@in.waw.pl>
In-Reply-To: <20120318225327.GA26977@bloggs.ozlabs.ibm.com>

On 03/18/2012 11:53 PM, Paul Mackerras wrote:

Show 13 quoted lines

> On Tue, Oct 04, 2011 at 10:08:13PM +0200, Marcus Karlsson wrote:
>
>> Teach gitk to respect log.showroot.
>
>> +set log_showroot true
>> +catch {
>> +    set log_showroot [exec git config --get log.showroot]
>> +}
>
> Since I mostly use gitk on the kernel, I'd prefer that log_showroot
> defaults to false if it isn't specified in the git config file.
> Defaulting to false would also be the smaller change in gitk
> behaviour.

I agree that in case of the kernel repo, log.showroot=false is more useful. But this somewhat special use case should not decide the policy. First of all, as an experienced git user you know how to set the config option, if you dislike the default. This new default targets new users. Secondly, this option only matters when you scroll all the way down and click on first commit. Probably doesn't happen too often, since the time required to read in the other ~300000 commit messages is pretty big too. If you want to look at the root commit, it's probably because your project started recently and your history is short. Thirdly, consistency between git-log and gitk is important.

Zbyszek