Re: [PATCH v3] gitk: Teach gitk to respect log.showroot

From: Paul Mackerras <paulus@samba.org>
Date: Oct 8, 2011, 06:47 UTC
Message-ID: <20111008064704.GA27056@bloggs.ozlabs.ibm.com>
In-Reply-To: <20111004200813.GA16596@kennedy.acc.umu.se>

On Tue, Oct 04, 2011 at 10:08:13PM +0200, Marcus Karlsson wrote:

> Teach gitk to respect log.showroot.

Sounds reasonable, ...

Show 6 quoted lines

> -	set cmd [concat | git diff-tree -r $flags $ids]
> +	set cmd [concat | git diff-tree -r]
> +	if {$log_showroot eq true} {
> +	    set cmd [concat $cmd --root]
> +	}
> +	set cmd [concat $cmd $flags $ids]

but is there any reason not to do it like this?

	if {$log_showroot} {
	    lappend flags --root
	}
	set cmd [concat | git diff-tree -r $flags $ids]

I.e., do you particularly want the --root before the other flags?

Paul.