git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parse-options: deprecate OPT_BOOLEAN

From
Jeff King <peff@peff.net>
Date
Sep 28, 2011, 03:58 UTC
Message-ID
<20110928035809.GC10662@sigill.intra.peff.net>
In-Reply-To
<7v39fhv8se.fsf@alter.siamese.dyndns.org>
On Tue, Sep 27, 2011 at 04:56:49PM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> It is natural to expect that an option defined with OPT_BOOLEAN() could be
> used in this way:
> [...]
> to easily tell three cases apart:
> 
>  - There is no mention of the `--option` on the command line;
>  - The variable is positively set with `--option`; or
>  - The variable is explicitly negated with `--no-option`.
> 
> Unfortunately, this is not the case. OPT_BOOLEAN() increments the variable
> every time `--option` is given, and resets it to zero when `--no-option`
> is given.

Yes, please. I remember being bitten by this at one point. Your transition plan makes sense to me.

Can OPT_UYN be folded into this, as well?
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 9 in “parse-options: deprecate OPT_BOOLEAN”
  1. parse-options: deprecate OPT_BOOLEANJunio C Hamano, Sep 27, 2011
  2. archive.c: use OPT_BOOL()Junio C Hamano, Sep 27, 2011
  3. Jeff KingSep 28, 2011
  4. Junio C HamanoSep 28, 2011
  5. Miles BaderSep 28, 2011
  6. 1/3 parseopt: add OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  7. 2/3 revert: use OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  8. 3/3 apply: use OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  9. Junio C HamanoSep 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.