From: Jeff King <peff@peff.net>
Date: Wed, 28 Sep 2011 03:58:09 GMT
Subject: Re: [PATCH] parse-options: deprecate OPT_BOOLEAN
Message-ID: <20110928035809.GC10662@sigill.intra.peff.net>
In-Reply-To: <7v39fhv8se.fsf@alter.siamese.dyndns.org>

On Tue, Sep 27, 2011 at 04:56:49PM -0700, Junio C Hamano wrote:

> It is natural to expect that an option defined with OPT_BOOLEAN() could be
> used in this way:
> [...]
> to easily tell three cases apart:
> 
>  - There is no mention of the `--option` on the command line;
>  - The variable is positively set with `--option`; or
>  - The variable is explicitly negated with `--no-option`.
> 
> Unfortunately, this is not the case. OPT_BOOLEAN() increments the variable
> every time `--option` is given, and resets it to zero when `--no-option`
> is given.

Yes, please. I remember being bitten by this at one point. Your
transition plan makes sense to me.

Can OPT_UYN be folded into this, as well?

-Peff