git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] apply: use OPT_NOOP_NOARG

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Sep 28, 2011, 17:47 UTC
Message-ID
<4E835DCA.5010708@lsrfire.ath.cx>
In-Reply-To
<4E835CFE.7020501@lsrfire.ath.cx>
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 builtin/apply.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index f2edc52..872e40a 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -3831,7 +3831,6 @@ int cmd_apply(int argc, const char **argv, const char *prefix_)
 	int i;
 	int errs = 0;
 	int is_not_gitdir = !startup_info->have_repository;
-	int binary;
 	int force_apply = 0;
 
 	const char *whitespace_option = NULL;
@@ -3850,12 +3849,8 @@ int cmd_apply(int argc, const char **argv, const char *prefix_)
 			"ignore additions made by the patch"),
 		OPT_BOOLEAN(0, "stat", &diffstat,
 			"instead of applying the patch, output diffstat for the input"),
-		{ OPTION_BOOLEAN, 0, "allow-binary-replacement", &binary,
-		  NULL, "old option, now no-op",
-		  PARSE_OPT_HIDDEN | PARSE_OPT_NOARG },
-		{ OPTION_BOOLEAN, 0, "binary", &binary,
-		  NULL, "old option, now no-op",
-		  PARSE_OPT_HIDDEN | PARSE_OPT_NOARG },
+		OPT_NOOP_NOARG(0, "allow-binary-replacement"),
+		OPT_NOOP_NOARG(0, "binary"),
 		OPT_BOOLEAN(0, "numstat", &numstat,
 			"shows number of added and deleted lines in decimal notation"),
 		OPT_BOOLEAN(0, "summary", &summary,
-- 
1.7.7.rc2
Previous: René ScharfeNext: Junio C Hamano
Message 8 of 9 in “parse-options: deprecate OPT_BOOLEAN”
  1. parse-options: deprecate OPT_BOOLEANJunio C Hamano, Sep 27, 2011
  2. archive.c: use OPT_BOOL()Junio C Hamano, Sep 27, 2011
  3. Jeff KingSep 28, 2011
  4. Junio C HamanoSep 28, 2011
  5. Miles BaderSep 28, 2011
  6. 1/3 parseopt: add OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  7. 2/3 revert: use OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  8. 3/3 apply: use OPT_NOOP_NOARGRené Scharfe, Sep 28, 2011
  9. Junio C HamanoSep 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.