From: Michal Kiedrowicz <michal.kiedrowicz@gmail.com>
Date: Thu, 05 May 2011 08:38:39 GMT
Subject: Re: [PATCH V2 4/5] git-grep: Learn PCRE
Message-ID: <20110505103839.2a051583@mkiedrowicz>
In-Reply-To: <4DC2567A.1060502@viscovery.net>

On 05.05.2011 09:49:14 +0200 Johannes Sixt <j.sixt@viscovery.net> wrote:

> Am 5/5/2011 9:41, schrieb Michal Kiedrowicz:
> > But I can abstract these calls to die_pcre_not_supported() to not
> > repeat die() message.
> 
> Gah! Don't over-engineer. The compiler will un-duplicate the message
> texts for you if you carefully copy-and-paste them.
> 
> -- Hannes

The whole point of using die_pcre_not_supported() is that it'll take
care of this "if you carefully copy-and-paste them" and remove
redundancy in _source code_, not binary. But still these die()'s are
minor nit (IMO).