git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] config: support values longer than 1023 bytes

From
Jeff King <peff@peff.net>
Date
Apr 10, 2011, 20:58 UTC
Message-ID
<20110410205851.GB2069@sigill.intra.peff.net>
In-Reply-To
<1302468858-7376-2-git-send-email-kusmabite@gmail.com>
On Sun, Apr 10, 2011 at 10:54:18PM +0200, Erik Faye-Lund wrote:
Show 10 quoted lines
> parse_value in config.c has a static buffer of 1024 bytes that it
> parse the value into. This can sometimes be a problem when a
> config file contains very long values.
> 
> It's particularly amusing that git-config already is able to write
> such files, so it should probably be able to read them as well.
> 
> Fix this by using a strbuf instead of a fixed-size buffer.
> 
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Looks fine to me.
Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Erik Faye-LundNext: Jeff King
Message 3 of 7 in “strbuf: make sure buffer is zero-terminated”
  1. 1/2 strbuf: make sure buffer is zero-terminatedErik Faye-Lund, Apr 10, 2011
  2. 2/2 config: support values longer than 1023 bytesErik Faye-Lund, Apr 10, 2011
  3. Jeff KingApr 10, 2011
  4. Jeff KingApr 10, 2011
  5. Erik Faye-LundApr 10, 2011
  6. Jeff KingApr 10, 2011
  7. Junio C HamanoApr 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.