Re: [PATCH v2 1/2] strbuf: make sure buffer is zero-terminated
On Sun, Apr 10, 2011 at 11:04:26PM +0200, Erik Faye-Lund wrote:
Show 11 quoted lines
> > It is more than just detach, though; the
> > NUL-termination is supposed to be an invariant of strbuf, so any code
> > just looking at "sb.buf" would be broken. So your code looks fine, but
> > you may want to mention that in the commit message.
> >
>
> You're right. How about something like this instead?
>
> strbuf_init does not zero-terminate the initial buffer when hint is
> non-zero. Fix this so we can rely on the string to be zero-terminated
> even if we haven't filled it with anything yet.