From: Jeff King <peff@peff.net>
Date: Sun, 10 Apr 2011 20:58:52 GMT
Subject: Re: [PATCH v2 2/2] config: support values longer than 1023 bytes
Message-ID: <20110410205851.GB2069@sigill.intra.peff.net>
In-Reply-To: <1302468858-7376-2-git-send-email-kusmabite@gmail.com>

On Sun, Apr 10, 2011 at 10:54:18PM +0200, Erik Faye-Lund wrote:

> parse_value in config.c has a static buffer of 1024 bytes that it
> parse the value into. This can sometimes be a problem when a
> config file contains very long values.
> 
> It's particularly amusing that git-config already is able to write
> such files, so it should probably be able to read them as well.
> 
> Fix this by using a strbuf instead of a fixed-size buffer.
> 
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>

Looks fine to me.

Acked-by: Jeff King <peff@peff.net>

-Peff