Re: [PATCH v2 1/2] strbuf: make sure buffer is zero-terminated

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Apr 10, 2011, 21:04 UTC
Message-ID: <BANLkTinKzatY-1kxLJ73TeDyMW175pr77A@mail.gmail.com>
In-Reply-To: <20110410205711.GA2069@sigill.intra.peff.net>

On Sun, Apr 10, 2011 at 10:57 PM, Jeff King <peff@peff.net> wrote:

Show 6 quoted lines

> On Sun, Apr 10, 2011 at 10:54:17PM +0200, Erik Faye-Lund wrote:
>
>> strbuf_init does not zero-terminate the initial buffer when hint is
>> non-zero. Fix this so strbuf_attach does not return garbage.
>
> s/attach/detach/ I think.

Indeed, thanks for catching it.

Show 5 quoted lines

> It is more than just detach, though; the
> NUL-termination is supposed to be an invariant of strbuf, so any code
> just looking at "sb.buf" would be broken. So your code looks fine, but
> you may want to mention that in the commit message.
>

You're right. How about something like this instead?

strbuf_init does not zero-terminate the initial buffer when hint is non-zero. Fix this so we can rely on the string to be zero-terminated even if we haven't filled it with anything yet.