From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 11 Jan 2011 18:39:27 GMT
Subject: Re: [PATCH] svndump.c: Fix a printf format compiler warning
Message-ID: <20110111183927.GF15133@burratino>
In-Reply-To: <4D2C9EB1.2050100@ramsay1.demon.co.uk>

Ramsay Jones wrote:

> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>  		if (key == keys.svn_fs_dump_format_version) {
>  			dump_ctx.version = atoi(val);
>  			if (dump_ctx.version > 2)
> -				die("expected svn dump format version <= 2, found %d",
> +				die("expected svn dump format version <= 2, found %"PRIu32,
>  				    dump_ctx.version);

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

I think we should just use "int", but that is a wider sweeping change
for another time.  Thanks.

Does gcc or sparse provide a warning that could have caught this
mistake?